Skip to content
This repository was archived by the owner on Jun 27, 2020. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
03f4b26
Raise gradle version.
Sep 5, 2018
602d875
Update all dependencies.
Sep 5, 2018
857ff38
#95. Kotlinify EditAccountActivity.
Sep 5, 2018
bba8d27
#95. Move EditAccountActivity to activity.account.edit package.
Sep 5, 2018
a942879
#95. Partly move logic from EditAccountActivity to EditAccountFragment.
Sep 5, 2018
ababa1e
#95. Completely move all logic to EditAccountFragment.
Sep 6, 2018
bc6c4c0
#95. Ongoing refactoring.
Sep 6, 2018
b49d2b1
#95. Add AccountRecordFragment.
Sep 6, 2018
05c19ab
#95. Display account records.
Sep 6, 2018
bd7615d
#95. Rename FragmentAccountRecords to FragmentAccountOperations.
Sep 6, 2018
85e09ab
#95. Kotlinify TransferController.
Sep 10, 2018
710f433
#95. Display transfers as records in account operations.
Sep 10, 2018
3c75b2c
#95. Refactor AccountOperationsFragment.
Sep 10, 2018
7cc5dae
#95. Add tabs to EditAccountActivity.
Sep 10, 2018
db929b8
#95. Add localization.
Sep 10, 2018
6b4b778
#95. Hide FAB when going to Operations tab.
Sep 11, 2018
b622cbd
#95. Updated .travis.yml.
Sep 11, 2018
84e3b7f
Merge pull request #156 from evgenii-kanivets/feature-95_account_oper…
Sep 11, 2018
3e76c15
#150. Add 'Delete' button to backup item view.
Sep 11, 2018
01e5fb2
#150. Implement delete backup listener.
Sep 12, 2018
b4af995
#150. Extract async tasks from BackupController.
Sep 12, 2018
64cae2d
#150. Refactore BackupListener.
Sep 12, 2018
e9c945e
#150. Consolidate OnBackupListener.
Sep 12, 2018
953ca7e
#150. Implement Dropbox backup removal.
Sep 15, 2018
3e396b0
Merge pull request #157 from evgenii-kanivets/feature-150_dropbox_del…
Sep 15, 2018
3bb5ab2
Add 'Removing backup' message.
Sep 15, 2018
24fbc63
#134. Add account goal to EditAccountFragment.
Sep 16, 2018
ea19a2c
#134. Formatting.
Sep 16, 2018
1be7fed
Merge pull request #158 from evgenii-kanivets/feature-134_account_goal
Sep 16, 2018
9fb0339
#153. Add 'NON susbstitution currency' setting.
Sep 16, 2018
1898059
#153. Substitute NON currency in RecordController.
Sep 17, 2018
8015367
#153. Substitute NON currency in AccountController.
Sep 17, 2018
b6924c7
#153. Fine tune CurrencyController.
Sep 17, 2018
1dd6dd4
#153. Fix RecordControllerTest.
Sep 17, 2018
69aab3f
Merge pull request #159 from evgenii-kanivets/feature-153_non_substit…
Sep 17, 2018
69e2186
#155. Fix record layout.
Sep 17, 2018
e824ff1
Merge pull request #160 from evgenii-kanivets/bugfix-155
Sep 17, 2018
6e9450a
Fix tests.
Sep 17, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#95. Completely move all logic to EditAccountFragment.
  • Loading branch information
Evgenii Kanivets committed Sep 6, 2018
commit ababa1eb13f548c8538d9b644ddf3ac6f1a8f249
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.view.Menu
import android.view.MenuItem

import com.blogspot.e_kanivets.moneytracker.R
import com.blogspot.e_kanivets.moneytracker.activity.account.edit.adapter.EditAccountFragmentPagerAdapter
import com.blogspot.e_kanivets.moneytracker.activity.base.BaseBackActivity
import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController
import com.blogspot.e_kanivets.moneytracker.entity.data.Account
Expand Down Expand Up @@ -38,15 +39,11 @@ class EditAccountActivity : BaseBackActivity() {
override fun initViews() {
super.initViews()

fabDone.setOnClickListener { /*done()*/ }
viewPager.adapter = EditAccountFragmentPagerAdapter(supportFragmentManager, account)
}

override fun onCreateOptionsMenu(menu: Menu): Boolean {
if (account.isArchived) {
menuInflater.inflate(R.menu.menu_archived_account, menu)
} else {
menuInflater.inflate(R.menu.menu_account, menu)
}
menuInflater.inflate(if (account.isArchived) R.menu.menu_archived_account else R.menu.menu_account, menu)
return true
}

Expand All @@ -59,18 +56,6 @@ class EditAccountActivity : BaseBackActivity() {
}
}

private fun done(title: String) {
val newAccount = Account(
account.id, title, account.curSum.toDouble(),
account.currency, account.goal, account.isArchived, account.color
)
val updated = accountController.update(newAccount) != null
if (updated) {
setResult(Activity.RESULT_OK)
finish()
}
}

private fun archive(): Boolean {
if (account == accountController.readDefaultAccount()) {
showToast(R.string.cant_archive_default_account)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package com.blogspot.e_kanivets.moneytracker.activity.account.edit.adapter

import android.support.v4.app.Fragment
import android.support.v4.app.FragmentManager
import android.support.v4.app.FragmentPagerAdapter
import com.blogspot.e_kanivets.moneytracker.activity.account.edit.fragment.EditAccountFragment
import com.blogspot.e_kanivets.moneytracker.entity.data.Account

class EditAccountFragmentPagerAdapter(fragmentManager: FragmentManager, private val account: Account) :
FragmentPagerAdapter(fragmentManager) {

override fun getItem(position: Int): Fragment {
return when (position) {
0 -> EditAccountFragment.newInstance(account)
else -> Fragment()
}
}

override fun getCount(): Int = 1

}
Original file line number Diff line number Diff line change
@@ -1,33 +1,38 @@
package com.blogspot.e_kanivets.moneytracker.activity.account.edit.fragment

import android.app.Activity
import android.os.Bundle
import android.support.v4.app.Fragment
import android.view.LayoutInflater
import android.support.design.widget.FloatingActionButton
import android.view.View
import android.view.ViewGroup
import com.blogspot.e_kanivets.moneytracker.R
import com.blogspot.e_kanivets.moneytracker.R.layout
import com.blogspot.e_kanivets.moneytracker.activity.base.BaseFragment
import com.blogspot.e_kanivets.moneytracker.controller.data.AccountController
import com.blogspot.e_kanivets.moneytracker.entity.data.Account
import kotlinx.android.synthetic.main.fragment_edit_account.*
import javax.inject.Inject

class EditAccountFragment() : Fragment() {
class EditAccountFragment : BaseFragment() {

@Inject
internal lateinit var accountController: AccountController

private lateinit var account: Account

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
arguments?.let { arguments -> account = arguments.getParcelable(KEY_ACCOUNT) }
}
override val contentViewId: Int = layout.fragment_edit_account

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? {
val rootView = inflater.inflate(R.layout.fragment_edit_account, container, false)
initViews()
return rootView
override fun initData() {
appComponent.inject(this@EditAccountFragment)
arguments?.let { arguments -> account = arguments.getParcelable(KEY_ACCOUNT) }
}

fun initViews() {
override fun initViews(view: View) {
etTitle.setText(account.title)
etGoal.setText(account.goal.toString())
viewColor.setBackgroundColor(account.color)

val fabDone = view.rootView.findViewById<FloatingActionButton>(R.id.fabDone)
fabDone.setOnClickListener { done() }
}

private fun done() {
Expand All @@ -40,6 +45,11 @@ class EditAccountFragment() : Fragment() {
account.id, title, account.curSum.toDouble(),
account.currency, account.goal, account.isArchived, account.color
)
val updated = accountController.update(newAccount) != null
if (updated) {
activity?.setResult(Activity.RESULT_OK)
activity?.finish()
}
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.blogspot.e_kanivets.moneytracker.activity.base

import android.os.Bundle
import android.support.v4.app.Fragment
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import com.blogspot.e_kanivets.moneytracker.MtApp
import com.blogspot.e_kanivets.moneytracker.di.AppComponent

abstract class BaseFragment : Fragment() {

protected val appComponent: AppComponent = MtApp.get().appComponent

protected abstract val contentViewId: Int

protected abstract fun initData()

protected abstract fun initViews(view: View)

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
initData()
}

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View? =
inflater.inflate(contentViewId, container, false)

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
super.onViewCreated(view, savedInstanceState)
initViews(view)
}
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.blogspot.e_kanivets.moneytracker.di;

import com.blogspot.e_kanivets.moneytracker.activity.account.edit.EditAccountActivity;
import com.blogspot.e_kanivets.moneytracker.activity.account.edit.fragment.EditAccountFragment;
import com.blogspot.e_kanivets.moneytracker.activity.charts.ChartsActivity;
import com.blogspot.e_kanivets.moneytracker.activity.external.BackupActivity;
import com.blogspot.e_kanivets.moneytracker.activity.external.ImportExportActivity;
Expand Down Expand Up @@ -81,4 +82,6 @@ public interface AppComponent {
void inject(MonthSummaryAdapter monthSummaryAdapter);

void inject(EditAccountActivity editAccountActivity);

void inject(EditAccountFragment editAccountFragment);
}