Skip to content

Commit ec8efe6

Browse files
committed
Removed apache dependency for hex string generation
1 parent e3e68c3 commit ec8efe6

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

lib/commons-codec-1.9.jar

-258 KB
Binary file not shown.

nbproject/project.properties

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ dist.jar=${dist.dir}/piwik-java-api-${project.version}.jar
3030
dist.javadoc.dir=${dist.dir}/javadoc
3131
endorsed.classpath=
3232
excludes=
33-
file.reference.commons-codec-1.9.jar=lib/commons-codec-1.9.jar
3433
file.reference.commons-logging-1.2.jar=lib/commons-logging-1.2.jar
3534
file.reference.hk2-api.jar=lib/hk2-api.jar
3635
file.reference.hk2-locator.jar=lib/hk2-locator.jar
@@ -54,7 +53,6 @@ javac.classpath=\
5453
${file.reference.pitest-ant-1.1.1.jar}:\
5554
${file.reference.sonar-ant-task-2.2.jar}:\
5655
${file.reference.javax.json-1.0.4.jar}:\
57-
${file.reference.commons-codec-1.9.jar}:\
5856
${file.reference.httpclient-4.4.jar}:\
5957
${file.reference.httpcore-4.4.jar}:\
6058
${file.reference.javaee-api-7.0.jar}

src/com/ge/corporate/piwik/tracking/PiwikRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import java.util.Map;
1818
import java.util.Random;
1919
import javax.json.JsonValue;
20-
import org.apache.commons.codec.binary.Hex;
20+
import javax.xml.bind.DatatypeConverter;
2121

2222
/**
2323
* A class that implements the <a href="https://developer.piwik.org/api-reference/tracking-api">
@@ -1451,7 +1451,7 @@ public String getUrlEncodedQueryString(){
14511451
public static String getRandomHexString(int length){
14521452
byte[] bytes = new byte[length/2];
14531453
new Random().nextBytes(bytes);
1454-
return new String(Hex.encodeHex(bytes));
1454+
return DatatypeConverter.printHexBinary(bytes);
14551455
}
14561456

14571457
/**

test/com/ge/corporate/piwik/tracking/PiwikRequestTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1142,7 +1142,7 @@ public void testGetUrlEncodedQueryString(){
11421142
*/
11431143
@Test
11441144
public void testGetRandomHexString(){
1145-
String s = request.getRandomHexString(10);
1145+
String s = PiwikRequest.getRandomHexString(10);
11461146

11471147
assertEquals(10, s.length());
11481148
Long.parseLong(s, 16);

0 commit comments

Comments
 (0)