Skip to content

Commit e3e68c3

Browse files
committed
Corrected malformed bulk trackind request body
1 parent 03abb73 commit e3e68c3

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

src/com/ge/corporate/piwik/tracking/PiwikTracker.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public HttpResponse sendBulkRequest(Iterable<PiwikRequest> requests, String auth
8484
JsonArrayBuilder ab = Json.createArrayBuilder();
8585

8686
for (PiwikRequest request : requests){
87-
ab.add(request.getQueryString());
87+
ab.add("?"+request.getQueryString());
8888
}
8989

9090
ob.add(REQUESTS, ab);
@@ -95,7 +95,8 @@ public HttpResponse sendBulkRequest(Iterable<PiwikRequest> requests, String auth
9595

9696
HttpClient client = getHttpClient();
9797
HttpPost post = new HttpPost(uriBuilder.build());
98-
post.setEntity(new StringEntity(ob.build().toString(), ContentType.APPLICATION_JSON));
98+
post.setEntity(new StringEntity(ob.build().toString(),
99+
ContentType.APPLICATION_JSON));
99100

100101
return client.execute(post);
101102
}

test/com/ge/corporate/piwik/tracking/PiwikTrackerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public void testSendBulkRequest_Iterable_StringFF() throws Exception{
139139
doReturn("query").when(request).getQueryString();
140140
requests.add(request);
141141
doReturn(client).when(piwikTracker).getHttpClient();
142-
doReturn(response).when(client).execute(argThat(new CorrectPostRequest("{\"requests\":[\"query\"]}")));
142+
doReturn(response).when(client).execute(argThat(new CorrectPostRequest("{\"requests\":[\"?query\"]}")));
143143

144144
assertEquals(response, piwikTracker.sendBulkRequest(requests, null));
145145
}
@@ -153,7 +153,7 @@ public void testSendBulkRequest_Iterable_StringFT() throws Exception{
153153
doReturn("query").when(request).getQueryString();
154154
requests.add(request);
155155
doReturn(client).when(piwikTracker).getHttpClient();
156-
doReturn(response).when(client).execute(argThat(new CorrectPostRequest("{\"requests\":[\"query\"],\"token_auth\":\"12345678901234567890123456789012\"}")));
156+
doReturn(response).when(client).execute(argThat(new CorrectPostRequest("{\"requests\":[\"?query\"],\"token_auth\":\"12345678901234567890123456789012\"}")));
157157

158158
assertEquals(response, piwikTracker.sendBulkRequest(requests, "12345678901234567890123456789012"));
159159
}

0 commit comments

Comments
 (0)