PR to yciabaud's PR – recursion! #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
commented
Mar 10, 2017
feross
commented
- do not filter out extra keys from 'update' or 'scrape' events, in WS and HTTP
- remove requestHandler option
- expose Swarm object for easy overriding
- test: remove UDP request handler test -- not possible
- test: change request handler test to new approach
Owner
|
Oh thank you for this changes, you are right this is totally fixing my issues and this looks less intrusive in the basecode. I am merging this and will update my implementation soon. |
Author
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.