Add http tracker announce url to warning messages.#561
Add http tracker announce url to warning messages.#561crass wants to merge 1 commit intowebtorrent:masterfrom
Conversation
This change is modeled on the way that the UDP tracker does warning messages. Also, add missing space to one of the error messages.
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Yes, it is still relevant. |
|
@crass maybe change it to |
Am I correct to understand you to be suggesting that I change As stated in the PR this is how the udp tracker does it. So for consistency, in my opinion, this should only be changed if and only if the udp tracker is also changed. Are you suggesting that also? Here's the bittorrent-tracker/lib/client/udp-tracker.js Lines 165 to 175 in 295c69a |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain: Warning message improvement
What changes did you make? (Give an overview)
Add http tracker announce url to warning messages. This change is modeled on the way that the UDP tracker does warning messages. Also, add missing space to one of the error messages.