fix: import package.json in an ES module compatible way#555
Open
fixxi wants to merge 2 commits intowebtorrent:masterfrom
Open
fix: import package.json in an ES module compatible way#555fixxi wants to merge 2 commits intowebtorrent:masterfrom
fixxi wants to merge 2 commits intowebtorrent:masterfrom
Conversation
Author
|
Is there a reason for the hesitation? |
|
@ThaUnknown I can confirm that this is a real issue and that this PR solves that issue. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Author
|
Yes, this is still relevant and nothing is blocking it. It just needs to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ X] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I imported
createRequirefrom 'module' to be able to require package.json.Which issue (if any) does this pull request address?
#554
Is there anything you'd like reviewers to focus on?