Skip to content

fix(parse-http): prevent announcement from peers with invalid ports #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SilentBot1 merged 1 commit into from
Mar 12, 2024
Merged

fix(parse-http): prevent announcement from peers with invalid ports #513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(parse-http): ignore announcements from peers with invalid announc… 
…ement ports.
  • Loading branch information
@SilentBot1
SilentBot1 committed Mar 11, 2024
commit 20d777a90472874fb02793d0da3dac749cf6d32d
2 changes: 1 addition & 1 deletion lib/server/parse-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function (req, opts) {
params.peer_id = bin2hex(params.peer_id)

params.port = Number(params.port)
if (!params.port) throw new Error('invalid port')
if (!params.port || params.port <= 0 || params.port > 65535) throw new Error('invalid port')

params.left = Number(params.left)
if (Number.isNaN(params.left)) params.left = Infinity
Expand Down