Use hex info_hash and peer_id throughout #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
There was a problem hiding this comment.
Note: this is a breaking change
Member
Author
|
@astro Can I get a review of this? Then I'll publish a new version (for real). I just wanted to get all these breaking changes into one major version release instead of multiple ones. |
Contributor
|
This looks like what I wanted. What I'm uncertain about are the round-trips through binary strings in the HTTP request and response parsing. Perhaps we should make the querystring* functions in common Buffer-aware? |
Merged
Member
Author
|
Long-term I think we may need to look into |
feross
added a commit
that referenced
this pull request
Dec 13, 2014
Use hex info_hash and peer_id throughout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.