Skip to content

Conversation

@ThaUnknown
Copy link
Member

@ThaUnknown ThaUnknown commented May 25, 2023

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:

What changes did you make? (Give an overview)
changed feross's simple-websocket to one maintained by me, since he stopped maintaining his for over a year now

this drops buffer and readable stream for streamx and uint8util from simple-websocket

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: [email protected]

@ThaUnknown ThaUnknown enabled auto-merge (squash) May 25, 2023 16:19
Copy link
Member

@SilentBot1 SilentBot1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working on a local build with multiple test clients via HTTP and WS.

@ThaUnknown ThaUnknown merged commit 3f01c29 into webtorrent:master May 25, 2023
webtorrent-bot pushed a commit that referenced this pull request May 25, 2023
## [10.0.3](v10.0.2...v10.0.3) (2023-05-25)

### Performance Improvements

* replace simple websocket with maintained one ([#464](#464)) ([3f01c29](3f01c29))
@webtorrent-bot
Copy link

🎉 This PR is included in version 10.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ThaUnknown ThaUnknown deleted the simple-websocket branch May 25, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants