perf: replace simple websocket with maintained one#464
Merged
ThaUnknown merged 1 commit intowebtorrent:masterfrom May 25, 2023
Merged
perf: replace simple websocket with maintained one#464ThaUnknown merged 1 commit intowebtorrent:masterfrom
ThaUnknown merged 1 commit intowebtorrent:masterfrom
Conversation
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview: 🚮 Removed packages: [email protected] |
SilentBot1
approved these changes
May 25, 2023
Member
SilentBot1
left a comment
There was a problem hiding this comment.
Confirmed working on a local build with multiple test clients via HTTP and WS.
webtorrent-bot
pushed a commit
that referenced
this pull request
May 25, 2023
## [10.0.3](v10.0.2...v10.0.3) (2023-05-25) ### Performance Improvements * replace simple websocket with maintained one ([#464](#464)) ([3f01c29](3f01c29))
|
🎉 This PR is included in version 10.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
changed feross's simple-websocket to one maintained by me, since he stopped maintaining his for over a year now
this drops buffer and readable stream for streamx and uint8util from simple-websocket