fix(events): Support of paused client event
#411
Conversation
|
🙌 Thanks for opening this pull request! You're awesome. |
pavloniym
changed the title
paused client eventpaused client event
|
Are the changes okay for merging? @DiegoRBaquero @feross |
|
is this part of a BEP? why weren't we handling it before? |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
@DiegoRBaquero, so sorry! Idea: add special flag to server configuration to ignore such custom events, without error throw |
|
Where do you see the error thrown? It should only be a warning and ignored |
|
If I understand you correctly: https://github.com/webtorrent/bittorrent-tracker/blob/master/lib/server/swarm.js#L51 In this place tracker return error as callback on client announce hook. I have a private torrent-tracker and more than 10% of users (300+ users) use Transmission. Many of them complaining about this error, I tried to explain them that "this error is normal" but not succeeded :) To keep server code clean and support only BEP events — my idea is to add special flag to server configuration to ignore such custom events, without error throw |
|
I see it in BEP21: http://bittorrent.org/beps/bep_0021.html More ref: https://trac.transmissionbt.com/ticket/5883 I guess we can include it, as long as no official BEP overrides it. |
|
🎉 Congrats on getting your first pull request landed! |
# [9.19.0](v9.18.6...v9.19.0) (2022-06-01) ### Features * **events:** Support of `paused` client event ([#411](#411)) ([ef76b3f](ef76b3f))
|
🎉 This PR is included in version 9.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[x] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Handle
pausedclient requestWhich issue (if any) does this pull request address?
Some torrent clients (e.g. Transmission torrent client) receive 'invalid event' on
pausedrequest.Is there anything you'd like reviewers to focus on?
No