Skip to content

Conversation

@Bruce-Hopkins
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[X ] Documentation update
[ ] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Updated server docs. Changed to fix syntax errors and also better match the default config for the server.

Which issue (if any) does this pull request address?
#403

Is there anything you'd like reviewers to focus on?
n/a

@welcome
Copy link

welcome bot commented Dec 26, 2021

🙌 Thanks for opening this pull request! You're awesome.

@Bruce-Hopkins
Copy link
Contributor Author

Are the changes okay for merging? @DiegoRBaquero

@DiegoRBaquero
Copy link
Member

We don't use var anymore. Also needs to match standard format

@Bruce-Hopkins
Copy link
Contributor Author

@DiegoRBaquero I made changes from var to const. Does this work?

@DiegoRBaquero DiegoRBaquero merged commit b21d2cc into webtorrent:master Jan 3, 2022
@welcome
Copy link

welcome bot commented Jan 3, 2022

🎉 Congrats on getting your first pull request landed!

@webtorrent-bot
Copy link

🎉 This PR is included in version 9.18.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants