Skip to content

Conversation

@Theadd
Copy link

@Theadd Theadd commented Sep 27, 2014

Fix fox #38

feross added a commit that referenced this pull request Oct 7, 2014
handle .* IP/PORTs (6 bytes) error
@feross feross merged commit 7e081f8 into webtorrent:master Oct 7, 2014
feross added a commit that referenced this pull request Oct 7, 2014
- emit 'warning' instead of 'error' because it's not a fatal error,
just a bad tracker response.
- made the try block more concise so it only catches the errors from
`string2compact`
@feross
Copy link
Member

feross commented Oct 7, 2014

Thanks - this looks good. I made a few changes:

  • emit 'warning' instead of 'error' because it's not a fatal error, just a bad tracker response.
  • made the try block more concise so it only catches the errors from string2compact

Published as 2.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants