fix: UDP url parsing

[alxhotel]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

• As noted in the comments of the code, there is still a bug in Chrome and Firefox which doesn't correctly parse UDP urls.

• The previous code didn't handle the UDP case in the first parsing of the URL:

bittorrent-tracker/client.js

Line 89 in 2a12b75

parsedUrl = new URL(announceUrl)

• This PR creates a new function called parseUrl in the common file to handle the special case for UDP urls, so that the code can be reused wherever is necessary.

Which issue (if any) does this pull request address?
Fixes webtorrent/webtorrent#2066

Is there anything you'd like reviewers to focus on?
Let me know if the implementation of parseUrl can be improved

[jimmywarting]

How about something like this instead:

str = 'udp://github.com'
url = new URL(str.replace(/^udp:/, 'http:'))

if (str.match(/^udp:/)) {
  Object.defineProperties(url, {
    href: { value: url.href.replace(/^http/, 'udp') },
    protocol: { value: url.protocol.replace(/^http/, 'udp') },
    origin: { value: url.origin.replace(/^http/, 'udp') }
  })
}

You will keep it as a URL instances and get support for the rest of the class (serialize to string, instance check, searchParams)

[alxhotel]

Neat, thanks @jimmywarting! I have updated the PR.

[feross]

LGTM!

[feross]

Nit: Since it's just being used to get a boolean, I prefer to use /^udp:/.test(str).

[DiegoRBaquero]

🎉 This PR is included in version 9.17.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀