Skip to content

Conversation

@alxhotel
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[X] Other, please explain:

What changes did you make? (Give an overview)
Add missing .gitignore similar to other repositories

Which issue (if any) does this pull request address?
None

Is there anything you'd like reviewers to focus on?
None

@DiegoRBaquero
Copy link
Member

Given that the tracker is also a standalone CLI app, I think we should have package-lock.

@alxhotel
Copy link
Member Author

Yep, good point @DiegoRBaquero. I have updated the PR

@alxhotel alxhotel requested a review from DiegoRBaquero May 21, 2021 10:20
@alxhotel alxhotel merged commit 30f154e into master May 24, 2021
@alxhotel alxhotel deleted the add_gitignore branch May 24, 2021 09:54
@feross
Copy link
Member

feross commented Jun 3, 2021

@DiegoRBaquero When people install the CLI app, don't they just use npm install bittorrent-tracker? The package-lock.json won't be used if they install from npm.

@DiegoRBaquero
Copy link
Member

@DiegoRBaquero When people install the CLI app, don't they just use npm install bittorrent-tracker? The package-lock.json won't be used if they install from npm.

You are right, none of our module are apps where we run npm install, and now that we have pinned dev deps, doesn't makes sense to have it

@DiegoRBaquero
Copy link
Member

🎉 This PR is included in version 9.17.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants