Allow HTTP Request to /stats and /stats.json route#342
Closed
Firaenix wants to merge 6 commits intowebtorrent:masterfrom
Closed
Allow HTTP Request to /stats and /stats.json route#342Firaenix wants to merge 6 commits intowebtorrent:masterfrom
Firaenix wants to merge 6 commits intowebtorrent:masterfrom
Conversation
Merge latest into fork
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I extracted the "stats" route code into a function and allowed it to be called by the
server.onHttpRequestmethod. This will allow easy extension of the bittorrent tracker by servers such as Express.Which issue (if any) does this pull request address?
None that I am aware of.
Is there anything you'd like reviewers to focus on?
Whoever it may concern.