Skip to content

Conversation

@KJ2ME
Copy link

@KJ2ME KJ2ME commented Feb 10, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Allow use ssl for use https and wss protocol.

@DiegoRBaquero
Copy link
Member

I like this, are full docs updated? We need to include CLI changes and tests for this to be fully done

@jumpersdevice
Copy link

@KJ2ME Thanks for this but where you should specify the certs? I've tried cloning the repo using your commits/tree but still no SSL and no place to specify the certs location.

@KJ2ME
Copy link
Author

KJ2ME commented Apr 18, 2020

@KJ2ME Thanks for this but where you should specify the certs? I've tried cloning the repo using your commits/tree but still no SSL and no place to specify the certs location.

In the readme.md I wrote an example: https://i.imgur.com/xy03izD.png

@KJ2ME
Copy link
Author

KJ2ME commented Apr 18, 2020

I like this, are full docs updated? We need to include CLI changes and tests for this to be fully done

I added an example of usage on readme.md.

About the test and CLI changes: I don't understand.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Jul 22, 2021
@alxhotel alxhotel removed the stale label Jul 23, 2021
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Sep 22, 2021
@alxhotel alxhotel removed the stale label Sep 22, 2021
@haywirez
Copy link

haywirez commented Jan 7, 2023

Was this approved but not merged? What's the recommended way to support wss:// ? (happy to contribute patches, just need some orientation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants