Skip to content

Error.message is read only on the QuickJS Runtime. #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DiegoRBaquero merged 2 commits into from
Mar 29, 2020
Merged

Error.message is read only on the QuickJS Runtime. #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29d2e6b
Error.message is read only on some platforms.
koush Feb 3, 2020
e5df6fc
fix: error param
DiegoRBaquero Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/client/udp-tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ class UDPTracker extends Tracker {
cleanup()
if (self.destroyed) return

if (err.message) err.message += ` (${self.announceUrl})`
try {
// Error.message is readonly on some platforms.
if (err.message) err.message += ` (${self.announceUrl})`
} catch (ignoredErr) {}
// errors will often happen if a tracker is offline, so don't treat it as fatal
self.client.emit('warning', err)
}
Expand Down