Wrap lexical declarations inside switch cases#305
Merged
DiegoRBaquero merged 4 commits intowebtorrent:masterfrom Dec 20, 2018
jusguy:fix-no-case-declarations
Merged
Wrap lexical declarations inside switch cases#305DiegoRBaquero merged 4 commits intowebtorrent:masterfrom jusguy:fix-no-case-declarations
DiegoRBaquero merged 4 commits intowebtorrent:masterfrom
jusguy:fix-no-case-declarations
Conversation
1 task
DiegoRBaquero
requested changes
Dec 20, 2018
Member
DiegoRBaquero
left a comment
DiegoRBaquero
left a comment
There was a problem hiding this comment.
I would prefer using blocks with brackets as shown in the correct example (https://eslint.org/docs/rules/no-case-declarations). Else now the variables are even shared on an upper scope, defeating the purpose of the rule.
added 2 commits
December 20, 2018 12:52
Contributor
Author
|
Agreed @DiegoRBaquero, I have changed it. |
DiegoRBaquero
approved these changes
Dec 20, 2018
jusguy
changed the title
Contributor
Author
|
❤️ Thanks for the fast review. |
Member
|
Thank you for the PR ! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to comply with the new proposed standard rule
no-case-declaration:standard/eslint-config-standard#137