Skip to content

Modernize lib/client #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DiegoRBaquero merged 3 commits into from
Nov 22, 2018
Merged

Modernize lib/client #297

DiegoRBaquero merged 3 commits into from
Nov 22, 2018

Conversation

@jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Oct 3, 2018 •
edited
Loading

  • Use class, const, let, etc
  • Replaced inherits with class extends
  • Removed self variable where it wasn't passed into a regular function
    • (only replaced self with this in arrow functions)

@jimmywarting jimmywarting mentioned this pull request Oct 17, 2018
Closed
18 tasks
@DiegoRBaquero DiegoRBaquero merged commit 16e735d into webtorrent:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoRBaquero DiegoRBaquero DiegoRBaquero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmywarting @DiegoRBaquero