Skip to content

Time out and clean up udp stopped messages #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 2 commits into from
Jun 5, 2014
Merged

Time out and clean up udp stopped messages #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48baf2b
Time out and clean up udp stopped messages
jhiesey Jun 5, 2014
effd911
Remove semicolons
jhiesey Jun 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,15 +172,16 @@ Tracker.prototype._requestUdp = function (requestUrl, opts) {
var socket = dgram.createSocket('udp4')
var transactionId = new Buffer(hat(32), 'hex')

if (opts.event !== 'stopped') {
// if we're sending a stopped message, we don't really care if it arrives, so don't
// set a timer
var timeout = setTimeout(function () {
timeout = null
cleanup()
var stopped = opts.event === 'stopped'
// if we're sending a stopped message, we don't really care if it arrives, so set
// a short timer and don't call error
var timeout = setTimeout(function () {
timeout = null
cleanup()
if (!stopped) {
error('tracker request timed out')
}, 15000)
}
}
}, stopped ? 1500 : 15000)

if (timeout && timeout.unref) {
timeout.unref()
Expand Down Expand Up @@ -264,7 +265,7 @@ Tracker.prototype._requestUdp = function (requestUrl, opts) {

function send (message) {
if (!parsedUrl.port) {
parsedUrl.port = 80;
parsedUrl.port = 80
}
socket.send(message, 0, message.length, parsedUrl.port, parsedUrl.hostname)
}
Expand Down Expand Up @@ -334,7 +335,7 @@ Tracker.prototype._handleResponse = function (requestUrl, data) {

var warning = data['warning message']
if (warning) {
self.client.emit('warning', warning);
self.client.emit('warning', warning)
}

if (requestUrl === self._announceUrl) {
Expand Down