Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions lib/client/http-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,11 @@ HTTPTracker.prototype._onAnnounceResponse = function (data) {
self._trackerId = trackerId
}

self.client.emit('update', {
var response = Object.assign({}, data, {
announce: self.announceUrl,
complete: data.complete,
incomplete: data.incomplete
infoHash: common.binaryToHex(data.info_hash)
})
self.client.emit('update', response)

var addrs
if (Buffer.isBuffer(data.peers)) {
Expand Down Expand Up @@ -248,15 +248,12 @@ HTTPTracker.prototype._onScrapeResponse = function (data) {
}

keys.forEach(function (infoHash) {
var response = data[infoHash]
// TODO: optionally handle data.flags.min_request_interval
// (separate from announce interval)
self.client.emit('scrape', {
var response = Object.assign(data[infoHash], {
announce: self.announceUrl,
infoHash: common.binaryToHex(infoHash),
complete: response.complete,
incomplete: response.incomplete,
downloaded: response.downloaded
infoHash: common.binaryToHex(infoHash)
})
self.client.emit('scrape', response)
})
}
15 changes: 6 additions & 9 deletions lib/client/websocket-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,11 +266,11 @@ WebSocketTracker.prototype._onAnnounceResponse = function (data) {
}

if (data.complete != null) {
self.client.emit('update', {
var response = Object.assign({}, data, {
announce: self.announceUrl,
complete: data.complete,
incomplete: data.incomplete
infoHash: common.binaryToHex(data.info_hash)
})
self.client.emit('update', response)
}

var peer
Expand Down Expand Up @@ -326,16 +326,13 @@ WebSocketTracker.prototype._onScrapeResponse = function (data) {
}

keys.forEach(function (infoHash) {
var response = data[infoHash]
// TODO: optionally handle data.flags.min_request_interval
// (separate from announce interval)
self.client.emit('scrape', {
var response = Object.assign(data[infoHash], {
announce: self.announceUrl,
infoHash: common.binaryToHex(infoHash),
complete: response.complete,
incomplete: response.incomplete,
downloaded: response.downloaded
infoHash: common.binaryToHex(infoHash)
})
self.client.emit('scrape', response)
})
}

Expand Down
4 changes: 3 additions & 1 deletion server.js
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,8 @@ function Server (opts) {
}
}

Server.Swarm = Swarm

Server.prototype._onError = function (err) {
var self = this
self.emit('error', err)
Expand Down Expand Up @@ -352,7 +354,7 @@ Server.prototype.createSwarm = function (infoHash, cb) {
if (Buffer.isBuffer(infoHash)) infoHash = infoHash.toString('hex')

process.nextTick(function () {
var swarm = self.torrents[infoHash] = new Swarm(infoHash, self)
var swarm = self.torrents[infoHash] = new Server.Swarm(infoHash, self)
cb(null, swarm)
})
}
Expand Down
74 changes: 74 additions & 0 deletions test/request-handler.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
var Buffer = require('safe-buffer').Buffer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests.

var Client = require('../')
var common = require('./common')
var fixtures = require('webtorrent-fixtures')
var test = require('tape')
var Server = require('../server')

var peerId = Buffer.from('01234567890123456789')

function testRequestHandler (t, serverType) {
t.plan(5)

var opts = { serverType: serverType } // this is test-suite-only option

class Swarm extends Server.Swarm {
announce (params, cb) {
super.announce(params, function (err, response) {
if (err) return cb(response)
response.complete = 246
response.extraData = 'hi'
cb(null, response)
})
}
}

// Use a custom Swarm implementation for this test only
var OldSwarm = Server.Swarm
Server.Swarm = Swarm
t.on('end', function () {
Server.Swarm = OldSwarm
})

common.createServer(t, opts, function (server, announceUrl) {
var client1 = new Client({
infoHash: fixtures.alice.parsedTorrent.infoHash,
announce: announceUrl,
peerId: peerId,
port: 6881,
wrtc: {}
})

client1.on('error', function (err) { t.error(err) })
if (serverType === 'ws') common.mockWebsocketTracker(client1)

server.once('start', function () {
t.pass('got start message from client1')
})

client1.once('update', function (data) {
t.equal(data.complete, 246)
t.equal(data.extraData.toString(), 'hi')

client1.destroy(function () {
t.pass('client1 destroyed')
})

server.close(function () {
t.pass('server destroyed')
})
})

client1.start()
})
}

test('http: request handler option intercepts announce requests and responses', function (t) {
testRequestHandler(t, 'http')
})

test('ws: request handler option intercepts announce requests and responses', function (t) {
testRequestHandler(t, 'ws')
})

// NOTE: it's not possible to include extra data in a UDP response, because it's compact and accepts only params that are in the spec!