add bufferutil as optional dependency #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
approved these changes
Mar 7, 2017
Member
feross
left a comment
feross
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the great feedback!
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufferutilgreatly improveswsperformance.The package now has prebuilt binaries for Node.js 4, 6 and 7 (darwin, win32 and linux).
This should help with #175.
Slightly off-topic: memory usage can be reduced by ~15% if
ws.upgradeReqis freed when it is no longer needed.