Wait up to 1s for pending requests before destroy()#194
Merged
Conversation
If the user calls: client.stop() client.destroy() We should ensure that the final 'stopped' message reaches the tracker server, even though the client will not get the response (because they destroyed the client and no more events will be emitted). If there are pending requests when destroy() is called, then a 1s timer is set after which point all requests are forcibly cleaned up. If the requests complete before the 1s timer fires, then cleanup happens right away (so we're not stuck waiting for the 1s timer). So, destroy() can happen one of three ways: - immediately, if no pending requests exist - after exactly 1s, if pending requests exist and they don't complete within 1s - less than 1s, if pending requests exist and they all complete before the 1s timer fires
feross
changed the title
This was referenced Jan 21, 2017
Member
Author
|
cc @CraigglesO |
CraigglesO
approved these changes
Jan 21, 2017
CraigglesO
left a comment
CraigglesO
left a comment
There was a problem hiding this comment.
IT WORKS!!!! I tested it using the current master branch of torrent discovery and I get an EVENT 3 back. Love it.
Member
Author
|
Since this is a large change, it would be nice to get a code review from one of the other maintainers before merge. |
|
Do you have a fax on how to become a contributor? |
Member
Author
|
@CraigglesO Yes, you can read about that here: https://github.com/feross/bittorrent-tracker/blob/master/CONTRIBUTING.md#project-governance 👍 |
Member
Author
|
This PR has been open a few days so I'm going to merge it now. Post-merge feedback is still welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user calls:
client.stop()
client.destroy()
We should ensure that the final 'stopped' message reaches the tracker
server, even though the client will not get the response (because they
destroyed the client and no more events will be emitted).
If there are pending requests when destroy() is called, then a 1s timer
is set after which point all requests are forcibly cleaned up. If the
requests complete before the 1s timer fires, then cleanup happens right
away (so we're not stuck waiting for the 1s timer).
So, destroy() can happen one of three ways:
within 1s
the 1s timer fires