Check if peek(peerId) is undefined#170
Merged
feross merged 1 commit intowebtorrent:masterfrom Aug 10, 2016
alxhotel:master
Merged
Check if peek(peerId) is undefined#170feross merged 1 commit intowebtorrent:masterfrom alxhotel:master
feross merged 1 commit intowebtorrent:masterfrom
alxhotel:master
Conversation
Contributor
|
Good catch thank you! |
| allPeers[peerId].leecher = true | ||
|
|
||
| // The peer could be evicted at this point | ||
| if (typeof peer !== 'undefined') { |
Member
There was a problem hiding this comment.
It's usually better to invert if-statements like this one to prevent another level of indentation.
This is better, IMO:
if (peer == null) returnAlso, it's better to be defensive and treat null like no peer as well, hence the ==.
Member
Author
There was a problem hiding this comment.
Ok, I'll keep it in mind for future PRs
Member
|
Thanks @alxhotel -- good catch. I just added you to this repo as a collaborator! 👍 |
Member
|
8.0.10 |
Member
Author
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.keys()creates a new array, so while iterating through those keys, one of the peers could have been evicted from the cache. This makespeek(peerId)returnundefined.