Merged
Conversation
Contributor
|
Nice! |
| } | ||
|
|
||
| if (req.method === 'GET' && req.url === '/stats') { | ||
| if (req.method === 'GET' && req.url === '/stats' || 'stats.json') { |
Contributor
There was a problem hiding this comment.
I believe something is missing here.
Contributor
|
I am interested in merging your PR, I am making the changes I proposed and writing a unit test. Thank you. |
yciabaud
added a commit
to yciabaud/bittorrent-tracker
that referenced
this pull request
Jun 7, 2016
yciabaud
added a commit
to yciabaud/bittorrent-tracker
that referenced
this pull request
Jun 7, 2016
Contributor
Member
|
Yeah, if there's no response from me for a while, it's fine to merge things. 👍 That's the power of being a collaborator. If there's something that's likely to be controversial, or something that you're not confident about (maybe not familiar with that part of the codebase, or it's extra tricky), then I would wait for another collaborator to say it looks good first. But you can use your best judgement. Btw, I left some comments on your followup commit yciabaud@d7a651f |
yciabaud
added a commit
to yciabaud/bittorrent-tracker
that referenced
this pull request
Jul 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.