Skip to content

fix tests #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
feross merged 1 commit into from
Mar 27, 2016
Merged

fix tests #140

feross merged 1 commit into from
Mar 27, 2016

Conversation

@feross
Copy link
Member

@feross feross commented Mar 27, 2016

No description provided.

@feross feross merged commit 96a8fab into master Mar 27, 2016
@feross feross deleted the fix-test branch March 27, 2016 03:31
@feross
Copy link
Member Author

feross commented Mar 27, 2016

So, moving the wrtc.close() call into the callback (so it happens after all the webrtc clients close their RTCPeerConnections, seems to fix things on node v5.

But it somehow started causing tests to fail on node v4. This is nonsense.

@yciabaud
Copy link
Contributor

yciabaud commented Mar 27, 2016

OK waiting for the last RTCPeerConnection seems good, what happens in v4?

@feross
Copy link
Member Author

feross commented Mar 27, 2016

Hangs forever, same as the original issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feross @yciabaud