buffer-equals instead buffer-equal#137
Merged
feross merged 1 commit intowebtorrent:masterfrom Mar 24, 2016
fanatid:feature/buffer-equals
Merged
buffer-equals instead buffer-equal#137feross merged 1 commit intowebtorrent:masterfrom fanatid:feature/buffer-equals
feross merged 1 commit intowebtorrent:masterfrom
fanatid:feature/buffer-equals
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer-equal not throwing
TypeErrorif one of arguments is notBuffer, but node buffer equals does.buffer-equals throwing
TypeErrorThis PR is useless for current code, but I think it will be right use function with right behavior.