reset initial values on destroy #135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It's better to just set all this state in |
| } | ||
|
|
||
| self.socket = null | ||
| self.reconnecting = false |
Member
There was a problem hiding this comment.
This isn't correct. This boolean needs to stay true until a 'connect' event is fired. Setting it to false here defeats the point of it.
Member
|
7.5.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a
WebsocketTrackeris destroyed and reconnects after the specified/default interval some initial values are removed (which causes an errors e.g. as .peers is not an object anymore).