Bugfix: Do not use params.ip to filter Websocket peers #124
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yciabaud
added a commit
that referenced
this pull request
Mar 14, 2016
Bugfix: Do not use params.ip to filter Websocket peers
Contributor
Author
|
I am merging this since this bug can be painful for users |
Member
|
Thanks for the PR! My hand was injured, so I was taking it easy for a few days. Thanks for figuring this out! |
Member
|
Released as 7.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced a bug in 7.4.0 because
params.ipis used to filter peers inSwarm._getPeers. To fix this, I propose the addition ofparams.typein the peer data to filter against this.What do you think?