Skip to content

Reconnect timeout improvement #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feross merged 3 commits into from
Mar 16, 2016
Merged

Reconnect timeout improvement #123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e2dbdc
Reconnect timeout increase lineally
DiegoRBaquero Mar 11, 2016
529203e
Max reconnect time
DiegoRBaquero Mar 11, 2016
050d95a
Variance and higher max
DiegoRBaquero Mar 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/client/websocket-tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ var Tracker = require('./tracker')
// boost, and saves browser resources.
var socketPool = {}

var RECONNECT_MINIMUM = 15 * 1000
var RECONNECT_MAXIMUM = 30 * 60 * 1000
var RECONNECT_VARIANCE = 30 * 1000
var RECONNECT_MINIMUM = 5 * 1000
var OFFER_TIMEOUT = 50 * 1000

inherits(WebSocketTracker, Tracker)
Expand All @@ -29,6 +30,7 @@ function WebSocketTracker (client, announceUrl, opts) {
self.peers = {} // peers (offer id -> peer)
self.socket = null
self.reconnecting = false
self.retries = 0

self._openSocket()
}
Expand Down Expand Up @@ -118,6 +120,7 @@ WebSocketTracker.prototype._onSocketConnect = function () {

if (self.reconnecting) {
self.reconnecting = false
self.retries = 0
self.announce(self.client._defaultAnnounceOpts())
}
}
Expand Down Expand Up @@ -233,10 +236,11 @@ WebSocketTracker.prototype._onSocketError = function (err) {

WebSocketTracker.prototype._startReconnectTimer = function () {
var self = this
var ms = Math.floor(Math.random() * RECONNECT_VARIANCE) + RECONNECT_MINIMUM
var ms = Math.floor(Math.random() * RECONNECT_VARIANCE) + Math.min(Math.pow(2, self.retries) * RECONNECT_MINIMUM, RECONNECT_MAXIMUM)

self.reconnecting = true
var reconnectTimer = setTimeout(function () {
self.retries++
self._openSocket()
}, ms)
if (reconnectTimer.unref) reconnectTimer.unref()
Expand Down