-
-
Notifications
You must be signed in to change notification settings - Fork 335
Closed
Description
As title, it seems https://github.com/webtorrent/bittorrent-tracker/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21 introduces socks module and only set it to false in browser but not chromeapp, so Brave Webtorrent build is failed as below.
03:54:54 ERROR in ./node_modules/socks/lib/socks-client.js
03:54:54 Module not found: Error: Can't resolve 'net' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'
03:54:54 ERROR in ./node_modules/socks/lib/socks-agent.js
03:54:54 Module not found: Error: Can't resolve 'tls' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'
cc @feross
Metadata
Metadata
Assignees
Labels
No labels