Skip to content

Brave Webtorrent buiild broken after [email protected] #397

@yrliou

Description

@yrliou

As title, it seems https://github.com/webtorrent/bittorrent-tracker/pull/356/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R21 introduces socks module and only set it to false in browser but not chromeapp, so Brave Webtorrent build is failed as below.

03:54:54  ERROR in ./node_modules/socks/lib/socks-client.js
03:54:54  Module not found: Error: Can't resolve 'net' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'
03:54:54  ERROR in ./node_modules/socks/lib/socks-agent.js
03:54:54  Module not found: Error: Can't resolve 'tls' in '/home/ubuntu/workspace/pr-brave-browser-fix-audit-8-31-linux/src/brave/node_modules/socks/lib'

cc @feross

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions