Skip to content

Removing ChangeLogItem when needed #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ElvisCSouza merged 2 commits into from
Jan 29, 2022
Merged

Removing ChangeLogItem when needed #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57cfb28
Removing changelog item when new state is diferent do closed and exis…
DiegoGalante Jan 29, 2022
978ffd1
Check if ChangeLogItem was released before delete it
DiegoGalante Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check if ChangeLogItem was released before delete it
  • Loading branch information
@DiegoGalante
DiegoGalante committed Jan 29, 2022
commit 978ffd1e51d3ab8e8e69c968fd9a692e1b3bc911
1 change: 1 addition & 0 deletions AzureDevopsTracker/Entities/ChangeLogItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ public class ChangeLogItem : Entity
public string Description { get; private set; }
public string WorkItemType { get; private set; }
public string ChangeLogId { get; private set; }
public bool WasReleased => string.IsNullOrEmpty(ChangeLogId?.Trim());

/*EF*/
public ChangeLog ChangeLog { get; private set; }
Expand Down
9 changes: 5 additions & 4 deletions AzureDevopsTracker/Services/AzureDevopsTrackerService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ public void CheckWorkItemAvailableToChangeLog(WorkItem workItem, Fields fields)
{
if (workItem.CurrentStatus != "Closed" &&
workItem.LastStatus == "Closed" &&
workItem.ChangeLogItem != null)
workItem.ChangeLogItem != null &&
!workItem.ChangeLogItem.WasReleased)
RemoveChangeLogItem(workItem);

if (workItem.CurrentStatus != "Closed" ||
Expand Down Expand Up @@ -200,10 +201,10 @@ public ChangeLogItem ToChangeLogItem(WorkItem workItem, Fields fields)

public void RemoveChangeLogItem(WorkItem workItem)
{
var changeLotItem = _changeLogItemRepository.GetById(workItem.ChangeLogItem?.Id).Result;
if (changeLotItem != null)
var changeLogItem = _changeLogItemRepository.GetById(workItem.ChangeLogItem?.Id).Result;
if (changeLogItem != null)
{
_changeLogItemRepository.Delete(changeLotItem);
_changeLogItemRepository.Delete(changeLogItem);
_changeLogItemRepository.SaveChangesAsync().Wait();

workItem.RemoveChangeLogItem();
Expand Down