Fix and improved bootstrap jobs module test.#875
Fix and improved bootstrap jobs module test.#875josecelano merged 1 commit intotorrust:developfrom GGLinnk:2024-05-20-fix-bs-jobs-mod-test
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #875 +/- ##
===========================================
- Coverage 78.88% 78.83% -0.05%
===========================================
Files 170 170
Lines 9395 9394 -1
===========================================
- Hits 7411 7406 -5
- Misses 1984 1988 +4 ☔ View full report in Codecov by Sentry. |
On O.S. with different language than english the BadTlsConfig source error message will differ from the compared one. This will fix this issue by matching the enum itself instead of relying on a string compare.
|
Sorry for all the force push, I try to pass as many tests as possible. |
|
ACK 9be9366 |
|
Additional note @josecelano : The project currently seems to work perfectly under Windows. |
Hi, have you seen this #325. To be honest, I have not tried to compile in Windows yet. If it's working, I would:
UPDATE: we could try with https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#using-a-matrix-strategy |
|
It' seems that 5 unit test are failing under windows. |
On non-English operating systems, the source
BadTlsConfigerror message will be different from the compared message.This solves the problem by matching the enumeration itself, rather than relying on a string comparison.