Use only non-defaults in toml config templates#858
Merged
josecelano merged 1 commit intotorrust:developfrom May 14, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #858 +/- ##
===========================================
- Coverage 78.83% 78.74% -0.10%
===========================================
Files 169 169
Lines 9341 9304 -37
===========================================
- Hits 7364 7326 -38
- Misses 1977 1978 +1 ☔ View full report in Codecov by Sentry. |
c6d3545 to
a465158
Compare
a465158 to
c91ba16
Compare
After implementing the configuration with Figment, it's now possible to omit values if they have a default value. Therefore we don't need to add all options in templates. We only need to add values that are overwriting deffault values.
c91ba16 to
445bd53
Compare
Member
Author
|
ACK 445bd53 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implementing the configuration with Figment, it's possible to omit values if they are defaults. Therefore, we don't need to add all options in templates. We only need to add values that overwrite the default values.
For example, the new configuration file for development environment (
share/default/config/tracker.development.sqlite3.toml) is:The only difference with the default values is UDP and HTTP services are enabled.
This makes it easier to maintain these templates and to see what changes have been made compared to the default values.