Refactor: tracker core service only needs the core config#857
Merged
josecelano merged 1 commit intotorrust:developfrom May 10, 2024
Merged
Conversation
abf79e8 to
0b857eb
Compare
0b857eb to
80e691b
Compare
80e691b to
ae77ebc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #857 +/- ##
===========================================
+ Coverage 78.75% 78.83% +0.07%
===========================================
Files 169 169
Lines 9293 9341 +48
===========================================
+ Hits 7319 7364 +45
- Misses 1974 1977 +3 ☔ View full report in Codecov by Sentry. |
Member
Author
|
ACK ae77ebc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #401
After extracting the
Coreconfig type, we don't need to pass the whole configuration to the tracker core service. We can pass only its config.