Add DashMap implementation for torrent repository and set as used one#581
Closed
mickvandijke wants to merge 1 commit intotorrust:developfrom
Closed
Add DashMap implementation for torrent repository and set as used one#581mickvandijke wants to merge 1 commit intotorrust:developfrom
mickvandijke wants to merge 1 commit intotorrust:developfrom
Conversation
… and set as used one
mickvandijke
had a problem deploying
to
coverage
GitHub Actions
Failure
Member
Author
|
I will include #567 as a part of this PR as well to fix any related failing tests. Especially for the ordering of torrents in the API response. |
Member
|
I guess this was superseded by #645, right @mickvandijke? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DashMap does not support ordering of keys that we use right now for our scrape responses, since DashMap works using multiple inner HashMaps (sharded).
When I implement the torrent repository limit, I plan on adding a new HashMap that keeps track of the storage priority of torrents. We could also use the ordering of that HashMap for our torrents and scrape responses.