Skip to content

Remove API endpoint without version prefix #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josecelano merged 1 commit into from
Apr 13, 2023
Merged

Remove API endpoint without version prefix #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/servers/apis/v1/routes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,7 @@ use super::context::{auth_key, stats, torrent, whitelist};
use crate::tracker::Tracker;

/// Add the routes for the v1 API.
///
/// > **NOTICE**: the old API endpoints without `v1` prefix are kept for
/// backward compatibility. For example, the `GET /api/stats` endpoint is
/// still available, but it is deprecated and will be removed in the future.
/// You should use the `GET /api/v1/stats` endpoint instead.
pub fn add(prefix: &str, router: Router, tracker: Arc<Tracker>) -> Router {
// Without `v1` prefix.
// We keep the old API endpoints without `v1` prefix for backward compatibility.
// todo: remove when the torrust index backend is using the `v1` prefix.
let router = auth_key::routes::add(prefix, router, tracker.clone());
let router = stats::routes::add(prefix, router, tracker.clone());
let router = whitelist::routes::add(prefix, router, tracker.clone());
let router = torrent::routes::add(prefix, router, tracker.clone());

// With `v1` prefix
let v1_prefix = format!("{prefix}/v1");
let router = auth_key::routes::add(&v1_prefix, router, tracker.clone());
let router = stats::routes::add(&v1_prefix, router, tracker.clone());
Expand Down