docs(issues): add issue specs #1868 and #1869; archive closed specs #1841 and #1853 - #1870
Conversation
- Add spec for torrust#1868: exclude workspace-coupling and torrust-tracker-torrent-repository-benchmarking from all container build cargo commands via --exclude flags (moved from drafts to open) - Add spec for torrust#1869: improve dependency-layer cache reuse within each workflow, including evaluation of cargo-chef cook/build split effectiveness given workspace-package churn (moved from drafts to open) - Update EPIC torrust#1840 subissues table: mark torrust#1853 DONE, add row 4.1 for torrust#1868, promote row 7 to open with torrust#1869 Related to torrust#1840, torrust#1853, torrust#1868, torrust#1869
Move closed issue specs from docs/issues/open/ to docs/issues/closed/: - torrust#1841 - Baseline workflow profiling and bottleneck analysis (PR torrust#1848) - torrust#1853 - Narrow Containerfile build targets to tracker image needs (PR torrust#1867) Update all references across EPIC, open specs, and draft specs to point to the new closed/ paths. Related to torrust#1840
There was a problem hiding this comment.
Pull request overview
Spec-only PR updating the workflow-performance documentation backlog under docs/issues/ by promoting two draft specs into open/, archiving two completed specs into closed/, and updating all cross-references (especially EPIC #1840 and baseline links) to match the new locations.
Changes:
- Added new open issue specs for #1868 and #1869 (promoted from drafts).
- Archived closed specs for #1841 and #1853 (moved to
docs/issues/closed/) and updated cross-links to point toclosed/. - Updated EPIC #1840 subissues table and several related draft specs to reference the archived baseline report location.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/issues/open/1869-1840-workflow-performance-dependency-layer-cache-reuse/ISSUE.md | Promotes the dependency-layer cache reuse spec to an open issue (#1869) and updates scope/tasks. |
| docs/issues/open/1868-1840-workflow-performance-exclude-irrelevant-workspace-members/ISSUE.md | Adds new open issue spec for excluding irrelevant workspace members in container builds (#1868). |
| docs/issues/open/1854-1840-workflow-performance-container-test-gating/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/open/1852-1840-workflow-performance-recipe-stage-manifest-only-copy/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/open/1851-1840-workflow-performance-dockerignore-audit/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/open/1840-improve-pr-workflow-performance-epic/EPIC.md | Updates subissues table to reflect archived specs and adds rows for #1868 and #1869. |
| docs/issues/drafts/1840-workflow-performance-split-external-dep-cache-layer/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/drafts/1840-workflow-performance-prebuilt-base-images/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/drafts/1840-workflow-performance-container-workflow-build-deduplication/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/drafts/1840-workflow-performance-buildkit-cargo-cache-mounts/ISSUE.md | Updates baseline-report reference to the archived closed/ location. |
| docs/issues/drafts/1840-workflow-performance-alternative-linker/ISSUE.md | Updates baseline-report reference (and inline mention) to the archived closed/ location. |
| docs/issues/closed/1853-1840-workflow-performance-containerfile-target-scope/ISSUE.md | Archives #1853 spec to closed/ and updates internal baseline links/paths accordingly. |
| docs/issues/closed/1841-1840-workflow-performance-baseline-analysis/ISSUE.md | Archives #1841 spec to closed/ and updates references within metadata. |
| docs/issues/closed/1841-1840-workflow-performance-baseline-analysis/evidence/container-baseline-20260527T210123Z.log | Adds/moves baseline evidence log into the archived folder. |
| docs/issues/closed/1841-1840-workflow-performance-baseline-analysis/benchmark-results-baseline.md | Updates references to point to archived closed/ paths for baseline spec and evidence. |
Comments suppressed due to low confidence (4)
docs/issues/open/1869-1840-workflow-performance-dependency-layer-cache-reuse/ISSUE.md:9
branchstill uses the{issue-number}placeholder even thoughgithub-issue: 1869is set. Using the concrete branch name makes the spec immediately actionable.
docs/issues/open/1869-1840-workflow-performance-dependency-layer-cache-reuse/ISSUE.md:77- Since this spec has been promoted to
docs/issues/open/(and the progress log notes that promotion), the "Spec drafted indocs/issues/drafts/" checkpoint should be checked as completed.
docs/issues/closed/1841-1840-workflow-performance-baseline-analysis/ISSUE.md:8 - This spec is being archived under
docs/issues/closed/, but the frontmatter still saysstatus: open. Many archived specs indocs/issues/closed/usestatus: closed, which better reflects the issue's lifecycle and avoids confusion when scanning metadata.
docs/issues/closed/1853-1840-workflow-performance-containerfile-target-scope/ISSUE.md:8 - This spec is being archived under
docs/issues/closed/, but the frontmatter still saysstatus: open. Settingstatus: closedkeeps the metadata consistent with other archived specs and reduces confusion when filtering/searching by status.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Set concrete branch name (was placeholder) - Fix related-artifacts path: drafts/1840-... -> open/1869-... - Update out-of-scope bullet to reference torrust#1869 instead of 'draft'
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1870 +/- ##
===========================================
- Coverage 77.77% 77.76% -0.02%
===========================================
Files 382 382
Lines 28637 28637
Branches 28637 28637
===========================================
- Hits 22273 22270 -3
- Misses 6054 6059 +5
+ Partials 310 308 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ACK ea582a7 |
Summary
Spec-only PR — no code changes. All changes are in
docs/issues/.New Issue Specs (opened and moved from
drafts/toopen/)Exclude irrelevant workspace members from container build #1868 — Exclude irrelevant workspace members from container build
(spec)
— Post-merge CI analysis of PR feat(container): narrow build target scope to tracker image needs (closes #1853) #1867 showed
workspace-couplingandtorrust-tracker-torrent-repository-benchmarkingare still compiled (~840s gap,19m03s total build step). Fix: add
--excludeflags to all 6 cargo commands.Improve dependency-layer cache reuse within each workflow #1869 — Improve dependency-layer cache reuse within each workflow
(spec)
— Investigate whether dependency cook layers are reliably reused when only app code
changes. T3 also evaluates whether the cargo-chef cook/build split delivers meaningful
benefit given workspace-package churn.
Archived Closed Specs (
open/→closed/)All cross-spec path references updated accordingly.
EPIC Update
EPIC #1840 subissues table updated:
closed/closed/open/pathRelated
Related to #1840, #1853, #1868, #1869