fix(issues): restore 1778 spec to open/ (issue was accidentally closed)#1782
Merged
josecelano merged 2 commits intoMay 13, 2026
Merged
Conversation
Issue torrust#1778 was closed by the PR that merged the issue spec into the repo. The implementation has not been done yet, so the issue and its spec should remain open. Issue torrust#1778 has been reopened on GitHub.
…create-issue Clarify when to use 'Closes #N' vs 'Related to #N' in PR bodies: - Spec-only PRs must use 'Related to #N' to avoid auto-closing the issue on merge. The issue should remain open until the implementation lands. - Implementation PRs (spec+impl combined, or impl-only) use 'Closes #N'. Changes: - open-pull-request/SKILL.md: replace single 'Closes #N' rule with an 'Issue Linking Rules' section containing a decision table and a diff- based check to identify the PR type; update post-creation checklist. - create-issue/SKILL.md: add 'Related to' warning in the workflow overview and in the spec-only PR step (Step 6), with a cross-reference to the open-pull-request skill.
Member
Author
|
ACK f75f2c6 |
There was a problem hiding this comment.
Pull request overview
This PR restores the Rust 2024 migration issue spec to docs/issues/open/ and updates agent skills to prevent spec-only PRs from accidentally closing implementation issues.
Changes:
- Restores issue #1778 migration spec under open issue docs.
- Adds spec-only vs implementation issue-linking guidance.
- Updates create-issue workflow warnings for spec-only PRs.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/issues/open/1778-migrate-to-rust-edition-2024.md |
Restores the open issue specification for Rust edition 2024 migration. |
.github/skills/dev/planning/create-issue/SKILL.md |
Adds warnings to use non-closing issue references for spec-only PRs. |
.github/skills/dev/git-workflow/open-pull-request/SKILL.md |
Adds issue-linking rules and post-creation checklist updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+79
to
+81
| - Diff touches only `docs/issues/` → spec-only → use `Related to #N` | ||
| - Diff touches source code, tests, or other non-spec files → implementation → use `Closes #N` | ||
| - Diff touches both spec and implementation → combined → use `Closes #N` |
|
|
||
| ## Issue Linking Rules | ||
|
|
||
| GitHub auto-closes an issue when a merged PR body contains `Closes #N`, `Fixes #N`, or `Resolves #N`. |
Comment on lines
+150
to
+151
| > Use `Related to #<number>` in the PR body, never `Closes #<number>` / `Fixes #<number>` / | ||
| > `Resolves #<number>`. Those keywords trigger GitHub auto-close on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes triggered by issue #1778 being accidentally closed when a spec-only PR was merged.
Changes
1. Restore 1778 spec to
open/docs/issues/open/1778-migrate-to-rust-edition-2024.mdwas moved toclosed/in PR #1781because issue #1778 appeared closed on GitHub. It was closed automatically when a PR containing
the issue spec used
Closes #1778in the body. The implementation has not been done yet.Issue #1778 has been reopened on GitHub.
2. Add PR-to-issue linking rules to skills
Update
open-pull-requestandcreate-issueskills to prevent the same mistake in the future:open-pull-request/SKILL.md: replace the singleCloses #Nrule with an"Issue Linking Rules" section containing a decision table (
Related tovsCloses)and a diff-based check to identify the PR type. Update the post-creation checklist.
create-issue/SKILL.md: add theRelated to #Nwarning in the spec-first workflowoverview and in Step 6 (spec-only PR), with a cross-reference to the
open-pull-requestskill.Rule added:
Related to #NCloses #NValidation
linter markdownpasseslinter cspellpasses