Skip to content

feat(tracker-core): widen mysql download counters to bigint (subissue 1525-07) #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josecelano merged 5 commits into from
May 1, 2026
Merged

feat(tracker-core): widen mysql download counters to bigint (subissue 1525-07) #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f0c9ef
docs(issues): rename 1525-07 spec to include GitHub issue number
josecelano Apr 30, 2026
a5936d1
docs(issues): update 1721-1525-07 scope to db-only widening
josecelano Apr 30, 2026
32b7e33
feat(tracker-core): widen mysql download counters to bigint
josecelano Apr 30, 2026
fa09390
fix(tracker-core): decode mysql metadata type bytes in tests
josecelano Apr 30, 2026
d67efdd
docs(issues): align 1525-08 references with 1721 scope
josecelano Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 0 additions & 228 deletions docs/issues/1525-07-align-rust-and-db-types.md
View file
Open in desktop

This file was deleted.

16 changes: 8 additions & 8 deletions docs/issues/1525-08-add-postgresql-driver.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ By the time this subissue is implemented:
a `bootstrap_legacy_schema()` helper for upgrading pre-v4 databases. Both backends have three
migration files.

- **1525-07** has widened `NumberOfDownloads` from `u32` to `u64`, added a fourth migration to
SQLite and MySQL, and added `decode_counter`/`encode_counter` helpers to both drivers. The
migration file layout at the end of `1525-07` is:
- **1525-07** has widened MySQL download-counter columns to `BIGINT` via a fourth migration,
added a history-aligned no-op migration for SQLite, and kept `NumberOfDownloads = u32`.
The migration file layout at the end of `1525-07` is:

```text
packages/tracker-core/migrations/
Expand Down Expand Up @@ -323,7 +323,7 @@ async fn drop_database_tables(&self) -> Result<(), Error> {

```rust
fn decode_counter(value: i64) -> Result<NumberOfDownloads, Error> {
u64::try_from(value).map_err(|err| Error::invalid_query(DRIVER, err))
u32::try_from(value).map_err(|err| Error::invalid_query(DRIVER, err))
}

fn encode_counter(value: NumberOfDownloads) -> Result<i64, Error> {
Expand All @@ -332,7 +332,7 @@ fn encode_counter(value: NumberOfDownloads) -> Result<i64, Error> {
```

Use these helpers in every place a counter column is read from or written to the database.
Do not use bare `as i64` casts or `as u64` casts.
Do not use bare `as i64` casts or `as u32` casts.

**`TorrentMetricsStore`, `WhitelistStore`, `AuthKeyStore` implementations**: Follow the same
structure as the SQLite and MySQL drivers, substituting `$1`/`$2` placeholders and the
Expand Down Expand Up @@ -482,7 +482,7 @@ Acceptance criteria:
- [ ] `create_database_tables()` calls `MIGRATOR.run()` with no legacy bootstrap.
- [ ] `drop_database_tables()` drops all five tables including `_sqlx_migrations`.
- [ ] All counter reads use `decode_counter`; all counter writes use `encode_counter`.
- [ ] No bare `as i64` or `as u64` casts in the driver.
- [ ] No bare `as i64` or `as u32` casts in the driver.

### Task 4 — Wire the PostgreSQL driver into the factory and setup

Expand Down Expand Up @@ -773,8 +773,8 @@ Acceptance criteria:
(PostgreSQL deferred here)
- Subissue `1525-06`: `docs/issues/1719-1525-06-introduce-schema-migrations.md` — migration
framework and history-alignment pattern
- Subissue `1525-07`: `docs/issues/1525-07-align-rust-and-db-types.md` — fourth migration
and `NumberOfDownloads = u64`
- Subissue `1525-07`: `docs/issues/1721-1525-07-align-rust-and-db-types.md` — fourth migration
and DB-only widening (`NumberOfDownloads = u32`)
- Reference PR: `#1695`
- Reference implementation branch: `josecelano:pr-1684-review` — see EPIC for checkout
instructions
Expand Down
2 changes: 1 addition & 1 deletion docs/issues/1525-overhaul-persistence.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ You can then browse or search it while working in the main repository.

### 7) Align persisted counters and Rust/SQL type boundaries

- Spec file: `docs/issues/1525-07-align-rust-and-db-types.md`
- Spec file: `docs/issues/1721-1525-07-align-rust-and-db-types.md`
Comment thread
josecelano marked this conversation as resolved.
- Outcome: explicit contract for persisted counters and numeric ranges, with any needed schema
changes delivered through migrations

Expand Down
Loading