Refactor: extract type ServiceBinding - #1423
Merged
josecelano merged 2 commits intoMar 31, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1423 +/- ##
===========================================
+ Coverage 83.15% 83.29% +0.14%
===========================================
Files 233 234 +1
Lines 17090 17147 +57
Branches 17090 17147 +57
===========================================
+ Hits 14211 14283 +72
+ Misses 2611 2593 -18
- Partials 268 271 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josecelano
marked this pull request as ready for review
March 28, 2025 18:41
josecelano
force-pushed
the
1422-refactor-extract-type-servicebinding
branch
from
March 28, 2025 18:47
38cddf9 to
0071103
Compare
josecelano
marked this pull request as draft
March 28, 2025 19:26
Member
Author
|
It's almost done. I only have to fix two tests because the service URL and the service check URL are not the same. |
josecelano
force-pushed
the
1422-refactor-extract-type-servicebinding
branch
from
March 31, 2025 09:21
33e76d3 to
a48e275
Compare
josecelano
force-pushed
the
1422-refactor-extract-type-servicebinding
branch
from
March 31, 2025 10:08
a48e275 to
f08d620
Compare
josecelano
marked this pull request as ready for review
March 31, 2025 10:08
Refactor: extract type `ServiceBinding`. It's the protocol + socket binding address for a service. - Protocols are only: udp, http and https (protocols used by the tracker now). - The port must be greater than zero (already assigned). - Any protocol and port combination is possible. For example: http protocol with a port different than 80.
josecelano
force-pushed
the
1422-refactor-extract-type-servicebinding
branch
from
March 31, 2025 10:09
f08d620 to
29fa324
Compare
Member
Author
|
ACK 29fa324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: extract type
ServiceBinding.It's the protocol + socket binding address for a service.
now).
protocol with a port different than 80.