Feature: Add listen_url field to the health check API#1416
Merged
josecelano merged 1 commit intoMar 26, 2025
Merged
Conversation
josecelano
added
Enhancement / Feature Request
```json
{
"status": "Ok",
"message": "",
"details": [
{
"listen_url": "http://0.0.0.0:7070/",
"binding": "0.0.0.0:7070",
"service_type": "http_tracker",
"info": "checking http tracker health check at: http://0.0.0.0:7070/health_check",
"result": {
"Ok": "200 OK"
}
}
]
}
```
The `binding` is not removed for back compatibility.
josecelano
force-pushed
the
1409-include-service-type-in-health-check-enpoint
branch
from
March 26, 2025 17:20
604a4e0 to
abfb733
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1416 +/- ##
===========================================
- Coverage 83.17% 83.15% -0.02%
===========================================
Files 233 233
Lines 17086 17090 +4
Branches 17086 17090 +4
===========================================
Hits 14211 14211
- Misses 2608 2611 +3
- Partials 267 268 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
ACK abfb733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an extra
listen_urlfield to th health check API endpoint:http://127.0.0.1:1313/health_check
{ "status": "Ok", "message": "", "details": [ { "listen_url": "http://0.0.0.0:7070/", "binding": "0.0.0.0:7070", "service_type": "http_tracker", "info": "checking http tracker health check at: http://0.0.0.0:7070/health_check", "result": { "Ok": "200 OK" } } ] }It includes the protocol + binding address.
The
bindingis not removed for back compatibility.NOTICE: HTTP URLs contain the trailing slash
"listen_url": "http://0.0.0.0:1212/"because it's the default behavior.