Log assertions: add assertions for log errors in UDP tracker#1165
Merged
josecelano merged 3 commits intoDec 26, 2024
Conversation
``` 2024-12-26T16:12:06.336340Z ERROR UDP TRACKER: response error error=cookie value is from future: 6831818432388564000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, expected < 1735229527.33634 remote_addr=127.0.0.1:35550 local_addr=127.0.0.1:36599 request_id=ce34c229-82c6-4a18-a60c-5eea1cf55919 transaction_id=123 ``` Added custom log with fields: - remote_addr - request_id - transaction_id
in UDP tracker. Only for the tests that is currently showing logging errors.
Member
Author
|
ACK 71e7ef7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1165 +/- ##
===========================================
- Coverage 76.18% 76.17% -0.01%
===========================================
Files 174 174
Lines 11601 11601
Branches 11601 11601
===========================================
- Hits 8838 8837 -1
Misses 2606 2606
- Partials 157 158 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you run this test:
cargo test -- --nocapture should_ban_the_client_ip_if_it_sends_more_than_10_requests_with_a_cookie_value_not_normalIt produces errors in logs:
This PR adds assertions for those logs.