Skip to content

New feature: capture recent logs for testing (rework)#1149

Merged
josecelano merged 1 commit intotorrust:developfrom
josecelano:feature-capture-logs-in-tests
Dec 23, 2024
Merged

New feature: capture recent logs for testing (rework)#1149
josecelano merged 1 commit intotorrust:developfrom
josecelano:feature-capture-logs-in-tests

Conversation

@josecelano
Copy link
Copy Markdown
Member

@josecelano josecelano commented Dec 23, 2024

Relates to:

This feature will be used in the future to write assertions about logs.

It also changes when we show logs running tests. If you run tests with:

cargo test

logs won't be shown. If you want to see the logs you have to execute tests
with:

cargo test -- --nocapture

This feature will be used in the future to write assertions about logs.

It also changes when we show logs running tests. If you run tests with:

```console
cargo test
```

logs win't be showed. If you want to see logs you have to execute tests
with:

```console
cargo test -- --nocapture
```
@josecelano
Copy link
Copy Markdown
Member Author

ACK d11ab32

@josecelano josecelano marked this pull request as ready for review December 23, 2024 12:13
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.13%. Comparing base (4a9dcef) to head (d11ab32).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/bootstrap/logging.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1149      +/-   ##
===========================================
- Coverage    76.24%   76.13%   -0.12%     
===========================================
  Files          173      173              
  Lines        11543    11551       +8     
  Branches     11543    11551       +8     
===========================================
- Hits          8801     8794       -7     
- Misses        2579     2590      +11     
- Partials       163      167       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sdterror output from tracing running tests

1 participant