Unfinished attempt to use the tracing-test crate#1147
Closed
josecelano wants to merge 2 commits intotorrust:developfrom
Closed
Unfinished attempt to use the tracing-test crate#1147josecelano wants to merge 2 commits intotorrust:developfrom
tracing-test crate#1147josecelano wants to merge 2 commits intotorrust:developfrom
Conversation
to make assertions about logs. More info: https://github.com/josecelano/tracing-test-bug
josecelano
had a problem deploying
to
coverage
GitHub Actions
Failure
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #1142
We want to write assertions for logs. I was working on this PR, and I realized there is a crate (tracing-test) that does exactly what I was trying to implement.
The problem is the crate has a bug with threads. So, I can't capture logs triggered in threads.
I've created a repo to reproduce it.
I've created this PR for the record.