Better peer ID recognition

[si14]

Hey folks!

I just released a peer ID registry/parser I was working on for my own BitTorrent related project. I think it can help Torrust to recognise more clients and also get their versions for free. Plus it'd be great to join our efforts on that kind of boring but foundational building blocks.

Let me know what you think, if you like the idea I'm happy to submit a PR changing the get_client_name implementation. It seems to be almost a drop-in replacement. I return Strings instead of 'static &str, but it should't be a problem as the only call site turns that &str into a String immediately anyway.

[josecelano]

Hey folks!

I just released a peer ID registry/parser I was working on for my own BitTorrent related project. I think it can help Torrust to recognise more clients and also get their versions for free. Plus it'd be great to join our efforts on that kind of boring but foundational building blocks.

Let me know what you think, if you like the idea I'm happy to submit a PR changing the get_client_name implementation. It seems to be almost a drop-in replacement. I return Strings instead of 'static &str, but it should't be a problem as the only call site turns that &str into a String immediately anyway.

Hi @si14, I think it's a great idea. We have started contributing to other crates like serde_bencode. And we also want to extract some packages in the future, for example, for the info_hash. We totally agree we should join efforts for the basic building block so that PR would be very welcomed. In case you can't do it eventaually, I'll take a look after our next major release. We are now focused on releasing a new major version.

cc @da2ce7

[josecelano]

Close via #477