Skip to content

Fix tsl_configtls_config typo across the codebase #1981

Description

@josecelano

Part of EPIC: #1978 — Configuration Overhaul (schema v3.0.0)
EPIC position: Subissue #2 of 9. Depends on #1979. Must be implemented before #1640 to avoid merge conflicts on http_tracker.rs.
Spec: docs/issues/drafts/configuration-overhaul-fix-tsl-typo.md

Goal

Fix the pervasive typo tsl_configtls_config across the entire codebase. This is a pre-existing typo (TLS, not TSL) that has propagated into ~13 Rust source files and ~8 documentation files. Since we are releasing config schema v3.0.0, this is the right time to fix it.

Background

The codebase consistently uses tsl_config instead of tls_config:

// packages/configuration/src/v2_0_0/http_tracker.rs
pub tsl_config: Option<TslConfig>,

// packages/configuration/src/v2_0_0/tracker_api.rs
pub tsl_config: Option<TslConfig>,

// packages/configuration/src/lib.rs
pub struct TslConfig { ... }

The struct name TslConfig and all field names tsl_config should be TlsConfig / tls_config. This is a purely mechanical rename with no behavioural change.

Scope

In Scope

  • Rename TslConfigTlsConfig in packages/configuration/src/lib.rs
  • Rename tsl_configtls_config in all config struct fields (HttpTracker, HttpApi)
  • Rename tsl_configtls_config in all consumers (~13 Rust files)
  • Rename tsl_configtls_config in all documentation (~8 markdown files)
  • Rename packages/axum-server/src/tsl.rspackages/axum-server/src/tls.rs
  • Update all use imports referencing the old module path

Out of Scope

  • Any functional changes to TLS configuration
  • Changing the TLS implementation itself

Implementation Plan

ID Task Notes
T1 Rename TslConfigTlsConfig struct In packages/configuration/src/lib.rs
T2 Rename tsl_configtls_config fields In HttpTracker and HttpApi config structs
T3 Rename tsl.rstls.rs In packages/axum-server/src/; update mod.rs
T4 Update all Rust consumers (~13 files) Search-and-replace tsl_configtls_config, TslConfigTlsConfig
T5 Update all documentation (~8 files) Search-and-replace in markdown files
T6 Run linter all and full test suite

Acceptance Criteria

  • TslConfig is renamed to TlsConfig everywhere
  • tsl_config is renamed to tls_config everywhere
  • packages/axum-server/src/tsl.rs is renamed to tls.rs
  • rg "tsl_config|TslConfig" returns zero matches
  • All tests pass
  • linter all exits with code 0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions