Track Cargo.lock for reproducible app builds#442
Merged
josecelano merged 2 commits intotorrust:mainfrom Apr 10, 2026
Merged
Conversation
Member
Author
|
ACK d65c810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR starts tracking Cargo.lock in Git and documents the decision with an ADR.
Problem
Cargo.lock was ignored in .gitignore, so it was missing after checkout in GitHub runners.
That made dependency resolution non-deterministic and caused workflow failures when a lockfile was expected.
Decision
Why this is correct for this repo
This workspace contains library crates, but the repository is primarily used as a runnable application/deployer.
For application-first repositories, versioning Cargo.lock improves reproducibility for both users and CI.
Files changed
Related workflows impacted