feat: [#332] add DNS setup reminder in provision command#333
Merged
josecelano merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
Display a DNS setup reminder after successful provisioning when custom domains are configured. The reminder helps users remember to update their DNS records to point to the server IP address. Changes: - Add DnsReminderView with conditional rendering based on domain presence - Add DnsReminderData DTO for view data transfer - Integrate DNS reminder display into provision controller workflow - Extract domains from tracker and Grafana ServiceInfo configurations - Add 5 unit tests covering various scenarios The reminder only appears when TLS domains are configured, listing all domains (tracker HTTP/API/health and Grafana) that need DNS setup.
Member
Author
|
ACK b98450b |
29 tasks
josecelano
added a commit
that referenced
this pull request
Feb 11, 2026
Mark task 10.1 (DNS setup reminder in provision command) as completed in the roadmap document and GitHub issue #1. Changes: - Mark task 10.1 as completed in docs/roadmap.md - Update reference to point to issue #332 and PR #333 - Delete completed issue specification file - Update roadmap GitHub issue #1 with completion status Related: #332, #333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Implements #332 - Display a DNS setup reminder after successful provisioning when custom domains are configured. This helps users remember to update their DNS records to point to the server IP address.
Changes
Architecture
Follows the project's DDD/MVC patterns:
src/presentation/views/commands/provision/dns_reminder.rs- Renders DNS reminder with warning icon, IP, and domain listsrc/presentation/controllers/provision/handler.rs- Orchestrates display after provisioningServiceInfofrom application layer for domain extractionBehavior
The DNS reminder:
Example Output
Testing
Acceptance Criteria
All criteria from the issue are met: