docs: [#285] add Docker Compose topology refactoring plan#286
Merged
Conversation
This commit adds a comprehensive refactoring plan for moving Docker Compose topology logic from Tera templates to the Rust domain layer. Key contents: - Domain rules analysis (~47 rules with test specifications) - 3-phase implementation plan (bind mounts, networks, topology aggregate) - 5-PR implementation strategy - Bug discovered: template handles invalid Grafana without Prometheus case - Issue spec document for plan review Related: #285
Member
Author
|
ACK 858a564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive refactoring plan for moving Docker Compose topology logic from Tera templates to the Rust domain layer.
Closes #285
Changes
New Files
docs/refactors/plans/docker-compose-topology-domain-model.md- Main refactoring plan (~1500 lines)docs/issues/285-docker-compose-topology-refactoring-plan.md- Issue specificationModified Files
docs/refactors/active-refactorings.md- Registered this refactoring as activePlan Highlights
Domain Rules Analysis
3-Phase Implementation
BindMountdomain typeNetworkenum for type-safe network managementDockerComposeTopologyaggregateImplementation Strategy
5 separate PRs planned:
Issues Discovered
grafana-integration-pattern.mdrecommends named volumes (will be superseded)Checklist
./scripts/pre-commit.shNotes